Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable embed SSR #987

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Re-enable embed SSR #987

merged 3 commits into from
Dec 18, 2024

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Dec 17, 2024 •
edited
Loading

Also fix the off-by-one on social cards.

@netlify Netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit 8a70df8
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/6762eca9bfb9ca0008235e75
😎 Deploy Preview https://deploy-preview-987.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 21 (🔴 down 27 from production)
Accessibility: 87 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 31.84% 7674 / 24098
🔵 Statements 31.84% 7674 / 24098
🔵 Functions 47.74% 339 / 710
🔵 Branches 75.71% 1113 / 1470
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/routes/(app)/documents/[id]-[slug]/+page.svelte 0% 0% 0% 0% 1-64
src/routes/embed/+layout.ts 0% 0% 0% 0% 1
Generated in workflow #532 for commit 8a70df8 by the Vitest Coverage Report Action

@eyeseast eyeseast requested a review from allanlasser December 18, 2024 14:56
@eyeseast eyeseast changed the title og:image is off by one Re-enable embed SSR Dec 18, 2024
@eyeseast eyeseast removed the request for review from duckduckgrayduck December 18, 2024 15:39
@allanlasser allanlasser linked an issue Dec 18, 2024 that may be closed by this pull request
Embeds are triggering Netlify Function executions #989
Open
@eyeseast eyeseast merged commit f7b3174 into main Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanlasser allanlasser allanlasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embeds are triggering Netlify Function executions
2 participants
@eyeseast @allanlasser